fix: add 10s per-file timeout to ingest to prevent hangs on large repos - #126
Closed
four-bytes-robby wants to merge 1 commit into
Closed
four-bytes-robby wants to merge 1 commit into
four-bytes-robby wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/ingest/index.ts">
<violation number="1" location="src/ingest/index.ts:393">
P1: `Promise.race` timeout does not cancel `processFile`, so timed-out files can still mutate DB/state after being marked timed out.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
|
||
| for (const [i, walked] of walkedFiles.entries()) { | ||
| try { | ||
| await Promise.race([ |
There was a problem hiding this comment.
P1: Promise.race timeout does not cancel processFile, so timed-out files can still mutate DB/state after being marked timed out.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/ingest/index.ts, line 393:
<comment>`Promise.race` timeout does not cancel `processFile`, so timed-out files can still mutate DB/state after being marked timed out.</comment>
<file context>
@@ -383,10 +386,27 @@ export async function ingestPath(
+
+ for (const [i, walked] of walkedFiles.entries()) {
+ try {
+ await Promise.race([
+ processFile(walked, i),
+ new Promise((_, reject) => setTimeout(() => reject(new Error('timeout')), FILE_TIMEOUT_MS))
</file context>
Member
Author
|
Superseded by #132 (timeout fix integrated there) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
Summary by cubic
Add a 10-second per-file timeout to the ingest pipeline to prevent hangs on large repos. Bumps
@four-bytes/four-opencode-brainto 1.7.4.Written for commit 9e7e40d. Summary will update on new commits.