fix(evm): sync full persistent account state when selecting a fork#14432
Open
AissataF wants to merge 1 commit intofoundry-rs:masterfrom
Open
fix(evm): sync full persistent account state when selecting a fork#14432AissataF wants to merge 1 commit intofoundry-rs:masterfrom
AissataF wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
On `select_fork`, the persistent-account loop only wrote `present_value` into slots that were already tracked in the target fork's journal, so slots newly added on the active fork and any `info` changes were dropped, and `SSTORE` could see a stale `original_value`. Now use `Entry::and_modify`/`or_insert_with` to insert missing slots, copy `info` from the active db, and initialize new `EvmStorageSlot`s with aligned `original_value`/`present_value`.
AissataF
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg,
stevencartavia and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
select_fork, the persistent-account loop only wrotepresent_valueinto slots that were already tracked in the target fork's journal, so slots newly added on the active fork and anyinfochanges were dropped, andSSTOREcould see a staleoriginal_value. Now useEntry::and_modify/or_insert_withto insert missing slots, copyinfofrom the active db, and initialize newEvmStorageSlots with alignedoriginal_value/present_value.