Star rating#159
Open
SavageWilliam wants to merge 6 commits into
Open
Conversation
Member
|
hey @SavageWilliam, seen this but wont have time to merge until next week probs cos im working/getting ready to fly out to israel n all that comes with it hope thats ok! |
Jbarget
requested changes
Mar 2, 2017
| } | ||
|
|
||
| .navbar__listitem { | ||
| list-style-type: none; |
Member
There was a problem hiding this comment.
2 space indentation here please :)
| <div class='resources'> | ||
| {{#each resources}} | ||
| <section class="resource"> | ||
| <h3 class="resource_title"><a href={{this.url}}>{{this.title}}</a></h3> |
Member
There was a problem hiding this comment.
a few empty lines here, please remove
| {{/if}} | ||
| </p> | ||
|
|
||
| {{# if ../credentials}} |
Member
There was a problem hiding this comment.
im just curious: what is this line saying?
Member
|
@SavageWilliam just going through my PRs. just a reminder |
Member
|
removing myself from assignment, assign me again if you want this merged in :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Satisfies #150 & #158
Uses sprites to display star rating
Works towards #86 - not complete