Change cheerio version to stable#126
Open
lisunovdv wants to merge 2 commits intofoundation:developfrom
Open
Conversation
Contributor
|
Hi @lisunovdv, thanks for your PR.
This is not correct. The SemVer range We should not pin the version to get security updates. |
DanielRuf
suggested changes
Jan 24, 2021
Co-authored-by: Daniel Ruf <827205+DanielRuf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


cheerio v0.20.0 or v1.0.0-rc.5 parses incorectly custom self-closing XML tags, e.g:
will become
And cheerio option
recognizeSelfClosing: falsecan't help.It's fixed only in the stable release of "cheerio" - v0.22.0 (that is used in inline-css
But
v1.0.0-rc.5has alatesttag so we need to write"cheerio": "0.22.0"' instead of"cheerio": "^0.22.0"`