Code revamp / compatible PHP 7.1, added checks for unavailable system… - #3
Open
stefgosselin wants to merge 1 commit into
Open
Code revamp / compatible PHP 7.1, added checks for unavailable system…#3stefgosselin wants to merge 1 commit into
stefgosselin wants to merge 1 commit into
Conversation
… calls within docker containers
Owner
|
Hi stefgosselin, Thanks for your efforts and I'm extremely sorry I couldn't respond earlier. Some reason I missed to see the notification of this PR. I've merged another PR with the same problem statement #4. Please see if it addresses your concern. If not, I will create a patch of your code and build v1.1 from it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I felt your package useful enough and updated it to run on php 7.1+.
I added a few checks on the reporting because some system calls are not always available in docker containers.
Your class was also passed through codesniffer, this is the reason formatting has changed somewhat. Feel free to merge if you deem worthwhile, good day!