Skip to content

Write file:// download locations without hyperlink conversion#291

Merged
soimkim merged 1 commit into
mainfrom
comm
Jul 3, 2026
Merged

Write file:// download locations without hyperlink conversion#291
soimkim merged 1 commit into
mainfrom
comm

Conversation

@soimkim

@soimkim soimkim commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Write file:// download locations without hyperlink conversion.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This change modifies the condition used in write_result_to_sheet within write_excel.py to determine when Excel cells are written using write_string. The condition now also includes values starting with file://, alongside the pre-existing check for long http:///https:// URLs.

Changes

Excel Cell Writing Condition

Layer / File(s) Summary
Update write_string condition
src/fosslight_util/write_excel.py
The condition for using write_string is extended to include file:// prefixed values in addition to long http(s) URLs.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: preventing file:// paths from being converted into hyperlinks.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch comm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@soimkim soimkim changed the title fix(write_excel): write file:// download locations without hyperlink … Write file:// download locations without hyperlink conversion Jul 3, 2026
@soimkim soimkim self-assigned this Jul 3, 2026
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Jul 3, 2026
@soimkim
soimkim merged commit 44513a0 into main Jul 3, 2026
8 checks passed
@soimkim
soimkim deleted the comm branch July 3, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant