Skip binaries via scancode-ignore-binaries

[soimkim]

• Improvements
  • Scans now automatically exclude binary files from ignore-rule processing.
  • Simplified scan handling can reduce unnecessary filesystem checks and improve scan efficiency.
  • Existing scan configuration and plugin behavior remain supported.

[coderabbitai]

Warning

Review limit reached

@soimkim, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7b027123-3963-409a-a351-2c8ef929a384

📥 Commits

Reviewing files that changed from the base of the PR and between 69481d8 and 523c0dd.

📒 Files selected for processing (3)

• pyproject.toml
• src/fosslight_source/_scancode_ignore_binaries.py
• src/fosslight_source/run_scancode.py

📝 Walkthrough

Walkthrough

Scancode execution now loads the scancode-ignore-binaries plugin, enables ignore_binaries=True, and replaces filesystem binary discovery and skip-filter construction with simplified coarse ignore-pattern generation.

Changes

Scancode ignore handling

Layer / File(s)	Summary
Binary-ignore capability wiring pyproject.toml, src/fosslight_source/run_scancode.py	Adds the pinned scancode-ignore-binaries dependency, imports the plugin, and enables binary ignoring in the scancode invocation.
Ignore-pattern simplification src/fosslight_source/run_scancode.py	Replaces legacy coverage, skip-filter, and binary-discovery helpers with _default_scancode_ignore_patterns() and wildcard extension handling.
Estimated code review effort: 3 (Moderate)	~20 minutes

Possibly related PRs

• fosslight/fosslight_source_scanner#265: Changes binary detection and exclusion behavior in the same scancode execution module.
• fosslight/fosslight_source_scanner#276: Reworks scancode ignore-rule construction in the same code path.
• fosslight/fosslight_source_scanner#283: Modifies scancode ignore-pattern generation for excluded directories.

Suggested labels: chore

Suggested reviewers: justinwonjaepark

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: switching ScanCode to skip binaries via the scancode-ignore-binaries plugin.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch perf

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pyproject.toml`:
- Around line 38-39: Remove the direct GitHub VCS dependency for
scancode-ignore-binaries from the project dependencies. Replace it with an
index-hosted package release, or vendor and register the plugin within the
project, while preserving the --ignore-binaries functionality without requiring
Git or GitHub access during installation.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ff5e232f-424c-49ca-9927-7576680c2e1b

📥 Commits

Reviewing files that changed from the base of the PR and between 6d6e133 and 69481d8.

📒 Files selected for processing (2)

• pyproject.toml
• src/fosslight_source/run_scancode.py

[soimkim]

Merge 전 Squash 필수