Skip to content

Pass --ui mode to fosslight_source analysis#189

Draft
soimkim wants to merge 3 commits into
mainfrom
token
Draft

Pass --ui mode to fosslight_source analysis#189
soimkim wants to merge 3 commits into
mainfrom
token

Conversation

@soimkim

@soimkim soimkim commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Forward ui_mode to run_scanners so ScanCode can run without only-findings when UI mode is enabled.

Summary by CodeRabbit

  • Bug Fixes
    • Improved source scanning so UI-mode behavior is applied consistently throughout the analysis process.

@soimkim soimkim self-assigned this Jul 14, 2026
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@soimkim, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2b478e28-b3e5-4f7c-b455-6fb936113b66

📥 Commits

Reviewing files that changed from the base of the PR and between 6c4ad4b and f16c09c.

📒 Files selected for processing (3)
  • pyproject.toml
  • src/fosslight_scanner/fosslight_scanner.py
  • tests/test_fosslight_scanner.py
📝 Walkthrough

Walkthrough

The source analysis wrapper accepts and forwards ui_mode. The scanner’s source analysis invocation now supplies the current UI mode.

Changes

Source analysis UI mode

Layer / File(s) Summary
UI mode propagation
src/fosslight_scanner/fosslight_scanner.py
source_analysis_wrapper forwards ui_mode to source_analysis, and run_scanner passes the scanner’s UI mode into the wrapper.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: fosslight-dev

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: forwarding UI mode into fosslight_source analysis.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch token

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/fosslight_scanner/fosslight_scanner.py`:
- Line 234: Update the Docker fallback invocation near the ui_mode argument to
pass the command as separate subprocess arguments rather than one quoted string,
include the --ui option so UI mode is preserved, and add a test covering the
Docker fallback branch.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cc66db8a-7c94-41c5-9f6f-a22b977c6e38

📥 Commits

Reviewing files that changed from the base of the PR and between 59fa2a0 and 6c4ad4b.

📒 Files selected for processing (1)
  • src/fosslight_scanner/fosslight_scanner.py

Comment thread src/fosslight_scanner/fosslight_scanner.py
Forward ui_mode to run_scanners so ScanCode can run without
only-findings when UI mode is enabled.
soimkim and others added 2 commits July 14, 2026 10:44
Pass the Docker command as a list to subprocess.run so it can launch,
and forward --ui so UI mode is preserved on the uninstalled-source path.
@soimkim
soimkim marked this pull request as draft July 15, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant