Conversation
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTimestamp-based naming is standardized across scanner outputs, temporary paths, logs, and comparison files. Final result logging switches to structured dumping with running-time formatting, and ChangesTimestamp helper adoption
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/fosslight_scanner/fosslight_scanner.py (1)
361-369: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUnused unpacked variables
final_excel_dirandresult_log.Static analysis flags these as unpacked-but-unused. Prefix with underscore to signal intent, since
download_sourceonly needs the temp directory path.♻️ Proposed fix
- success, final_excel_dir, result_log = init(out_dir) + success, _final_excel_dir, _result_log = init(out_dir)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/fosslight_scanner/fosslight_scanner.py` around lines 361 - 369, The unpacked values from init(out_dir) in download_source are not used, so rename final_excel_dir and result_log to underscore-prefixed variables to make the intent explicit and satisfy static analysis. Keep the current control flow and only retain the values actually needed by download_source, using the existing init and download_source symbols to locate the unpacking site.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/fosslight_scanner/fosslight_scanner.py`:
- Around line 361-369: The unpacked values from init(out_dir) in download_source
are not used, so rename final_excel_dir and result_log to underscore-prefixed
variables to make the intent explicit and satisfy static analysis. Keep the
current control flow and only retain the values actually needed by
download_source, using the existing init and download_source symbols to locate
the unpacking site.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: df82a23f-bdb7-46cf-983e-ecef0ef1daec
📒 Files selected for processing (2)
src/fosslight_scanner/_run_compare.pysrc/fosslight_scanner/fosslight_scanner.py
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/fosslight_scanner/fosslight_scanner.py`:
- Around line 168-171: `run_main()` is dropping the `result_log` returned by
`init()`, so URL scans never carry the `Tool Info` metadata into
`run_scanner()`. Update the URL-scan flow in `fosslight_scanner.py` so
`download_source()` and the `run_main()` branch both preserve and pass through
`result_log` instead of replacing it with an empty dict. Also adjust any
callers/tests that assume the old return shape, using the `init()`,
`download_source()`, and `run_scanner()` symbols to locate the affected paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6d888ded-8cd4-4de8-95f7-902686480793
📒 Files selected for processing (4)
pyproject.tomlsrc/fosslight_scanner/_run_compare.pysrc/fosslight_scanner/common.pysrc/fosslight_scanner/fosslight_scanner.py
✅ Files skipped from review due to trivial changes (1)
- pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (1)
- src/fosslight_scanner/_run_compare.py
Summary by CodeRabbit
fosslight_utildependency version constraint to a newer range.