Skip to content

Use POSIX path separators in binary report paths on Windows#211

Merged
soimkim merged 1 commit into
mainfrom
path
Jul 16, 2026
Merged

Use POSIX path separators in binary report paths on Windows#211
soimkim merged 1 commit into
mainfrom
path

Conversation

@soimkim

@soimkim soimkim commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Align source_name_or_path with fosslight_source by reusing the already normalized relative path so SRC/BIN sheet paths stay comparable.

Align source_name_or_path with fosslight_source by reusing the already
normalized relative path so SRC/BIN sheet paths stay comparable.
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Binary file entries now store precomputed POSIX-style relative paths in source_name_or_path, producing consistent path formatting in generated reports across platforms.

Changes

Binary path normalization

Layer / File(s) Summary
Relative source path assignment
src/fosslight_binary/binary_analysis.py
get_file_list assigns each binary item's source_name_or_path from the normalized relative path rather than stripping the root from the full filesystem path.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: bjk7119

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: normalizing Windows binary report paths to POSIX separators.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@soimkim soimkim self-assigned this Jul 15, 2026
@soimkim soimkim added the bug fix [PR] Fix the bug label Jul 15, 2026
@soimkim soimkim requested a review from bjk7119 July 15, 2026 23:26
@soimkim soimkim merged commit 2e04337 into main Jul 16, 2026
7 checks passed
@soimkim soimkim deleted the path branch July 16, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug fix [PR] Fix the bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant