Disallow mut ref to inner Vec for NEVec, allow ref and mut ref to slice#51
Open
MOZGIII wants to merge 1 commit into
Open
Disallow mut ref to inner Vec for NEVec, allow ref and mut ref to slice#51MOZGIII wants to merge 1 commit into
MOZGIII wants to merge 1 commit into
Conversation
Allowing mut access to inner Vec much allows breaking the non-emptyness invariant.
Author
|
@fosskers there's more work to do in this domain, like |
Owner
|
Can you provide a code example that demonstrates the invariant being violated? |
Author
let mut nevec: NEVec<u8> = ...;
let vecmut: &mut Vec<u8> = nevec.as_mut();
*vecmut = vec![]; |
Owner
|
Thanks, I'll test with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing mut access to inner Vec much allows breaking the non-emptyness invariant.