fix: reword pinned-query opt-in warning to "can't verify locally" (2.4.3)#44
Merged
Merged
Conversation
…4.3)
The 2.4.1 warning fires on any pinned (query_id) map with an opt-in feature
enabled — the Health page can't read a pinned query's contents — so it also
fires after publishing has already fixed the query. Its wording ("silently
ignored, so nothing new syncs") read as a confirmed failure and confused a
design partner who had just fixed it. Reword to a "Pinned — can't verify
locally" heads-up that points at Export Live Query Drift to confirm
(source_matches_bundled), instead of asserting failure. Wording only; no
behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 2.4.1 pinned-query opt-in Health warning fires on any
query_idmap with an opt-in feature enabled — the Health page can't read a pinned query's contents locally — so it also fires after publishing has already fixed the query. Its wording ("silently ignored, so nothing new syncs") reads as a confirmed failure. A design partner who had just published + refreshed saw the banner and thought the fix hadn't worked.Change
Wording only, no behavior change:
source_matches_bundled) first; only if it mismatches, Publish Bundled Queries → Refresh Query IDs → re-sync.Severity stays
warn(still a legit unverifiable-config heads-up); tests updated.