Skip to content

Starting modularization of the library.#64

Open
loiseaujc wants to merge 14 commits into
fortran-lang:mainfrom
loiseaujc:linting
Open

Starting modularization of the library.#64
loiseaujc wants to merge 14 commits into
fortran-lang:mainfrom
loiseaujc:linting

Conversation

@loiseaujc
Copy link
Copy Markdown
Contributor

@loiseaujc loiseaujc commented Feb 5, 2026

Following what I discussed about in #61, this PR starts setting up the modularization of the package.
It includes the following changes:

  • All the lowest-level routines, i.e.pass* and rad* subroutines, are now included in dedicated modules defining the appropriate interfaces.
  • In preparation of the fypp-ification to support different kinds, the module fftpack_kinds has now been templated.

Some linting with fortitude has also been done.

Ping: @perazz, @zoziha

PS: Most of the changes are in fftpack_legacy_drivers_*. The rest essentially is just some formatting.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 99.12358% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.24%. Comparing base (525e474) to head (70d9d9a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/fftpack_ifftshift.f90 0.00% 6 Missing ⚠️
src/fftpack_dct.f90 93.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #64       +/-   ##
===========================================
+ Coverage   81.16%   97.24%   +16.07%     
===========================================
  Files          68       50       -18     
  Lines        2140     2140               
  Branches      205      203        -2     
===========================================
+ Hits         1737     2081      +344     
+ Misses        403       59      -344     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@zoziha zoziha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @loiseaujc . LGTM, and all tests have passed.

Comment thread example/example_bench01_zfft.f90 Outdated
Comment thread example/example_bench02_zfft.f90 Outdated
Comment thread example/example_bench03_dfft.f90 Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

loiseaujc and others added 3 commits February 6, 2026 09:40
Co-authored-by: ZUO Zhihua <zuo.zhihua@qq.com>
Co-authored-by: ZUO Zhihua <zuo.zhihua@qq.com>
Co-authored-by: ZUO Zhihua <zuo.zhihua@qq.com>
@loiseaujc
Copy link
Copy Markdown
Contributor Author

Hadn't realized that the search-replace rk to dp had been applied to the print. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants