Starting modularization of the library.#64
Open
loiseaujc wants to merge 14 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
===========================================
+ Coverage 81.16% 97.24% +16.07%
===========================================
Files 68 50 -18
Lines 2140 2140
Branches 205 203 -2
===========================================
+ Hits 1737 2081 +344
+ Misses 403 59 -344 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zoziha
approved these changes
Feb 6, 2026
Contributor
zoziha
left a comment
There was a problem hiding this comment.
Thanks, @loiseaujc . LGTM, and all tests have passed.
Co-authored-by: ZUO Zhihua <zuo.zhihua@qq.com>
Co-authored-by: ZUO Zhihua <zuo.zhihua@qq.com>
Co-authored-by: ZUO Zhihua <zuo.zhihua@qq.com>
Contributor
Author
|
Hadn't realized that the search-replace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following what I discussed about in #61, this PR starts setting up the modularization of the package.
It includes the following changes:
pass*andrad*subroutines, are now included in dedicated modules defining the appropriate interfaces.fftpack_kindshas now been templated.Some linting with
fortitudehas also been done.Ping: @perazz, @zoziha
PS: Most of the changes are in
fftpack_legacy_drivers_*. The rest essentially is just some formatting.