Repository navigation
feat(secretsdump): support -just-dc-user in VSS - #2378
Open
CobblePot59 wants to merge 1 commit into
Open
CobblePot59 wants to merge 1 commit into
CobblePot59 wants to merge 1 commit into
Conversation
…ot modes Previously -just-dc-user was rejected when combined with -use-vss (or the WMI shadow snapshot NTDS method), even though filtering a single account out of an offline NTDS.DIT only requires a sAMAccountName match. Add an offline equivalent of the DRSUAPI -just-dc-user targeting: a new __isRequestedUser() helper compares each datatable record sAMAccountName against the requested account (accepting DOMAIN\user, DOMAIN/user or bare user, case-insensitively) and is applied to both the cached users and the main datatable loop. -ldapfilter stays unsupported in these modes since it relies on a live LDAP query against the DC, which has no offline equivalent here.
5 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously -just-dc-user was rejected when combined with -use-vss (or the WMI shadow snapshot NTDS method), even though filtering a single account out of an offline NTDS.DIT only requires a sAMAccountName match.
Add an offline equivalent of the DRSUAPI -just-dc-user targeting: a new __isRequestedUser() helper compares each datatable record sAMAccountName against the requested account (accepting DOMAIN\user, DOMAIN/user or bare user, case-insensitively) and is applied to both the cached users and the main datatable loop.