Repository navigation
Fix ccache Principal encoding for non-ASCII names - #2377
Merged
anadrianmanrique merged 1 commit intoNov 18, 2026
Merged
Conversation
3 of 14 tasks
Collaborator
|
tested ok. will follow up the unicode chars in SPN case in a separate PR |
Contributor
Author
Thanks for being so responsive! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CCache.Principal.fromPrincipal()storedstrparts as-is.Structurethen packed them as latin-1, which raisesUnicodeEncodeErrorfor any character beyond U+00FF (e.g. a Cyrillic account name), and length counted characters instead of bytes, so even latin-1 names with multi-byte UTF-8 forms produced a wrong length prefix.Parts are now encoded to UTF-8 up front, so the byte count is correct and non-ASCII principals serialize. bytes input is passed through unchanged, so existing callers are unaffected. All principals go through
fromPrincipal(fromTGT,fromTGS,fromKirbi), so this single change covers them all.Found while dumping TGTs from a Russian-locale Windows host with NetExec, where the built-in
Администраторaccount could not be written to a ccache.Before :
After :