Repository navigation
[par.py] Fix opnum 39 response class in OPNUMS - #2310
Merged
Merged
Conversation
Collaborator
|
Hi, thank you for this PR, everything looks good, im merging it now |
Collaborator
|
followed up at #2367. [MS-PAR] Add RpcAsyncDeletePrinterDriver call and tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Small fix in
impacket/dcerpc/v5/par.py: the OPNUMS entry for opnum 39(
RpcAsyncAddPrinterDriver) currently lists the request class as its ownresponse class:
while
RpcAsyncAddPrinterDriverResponseis defined right above it and isotherwise never referenced. Every other entry in the table follows the
(request, response)convention, so this looks like a copy-paste slippresent since the initial MS-PAR implementation (29ad579, 2021) rather
than intentional.
Proposed change (one line):
Notes:
response class by name convention (
<RequestClass>Response), so the tableis not consulted by the request path today. The change keeps the declared
opnum -> (request, response) mapping consistent for readers and tooling.
"Not yet" in tests/dcerpc/test_par.py).
Happy to adjust the approach if you'd prefer these tables handled differently.
Thanks!