Repository navigation
Fix LDAP add() failing with TypeError when using list-valued attributes - #2112
Merged
anadrianmanrique merged 1 commit intoFeb 9, 2026
Conversation
Contributor
|
Can you share the code that lead to the crash? |
Contributor
Author
Contributor
Contributor
Author
|
Yeah, I don't understand the difference between our two cases |
2 of 13 tasks
Contributor
|
@anadrianmanrique you said here that you tested the changes with impackets addcomputer script. You didn't have any issues right? Is this perhaps a version discrepancy with pyasn? Any other ideas why it worked with your and my code but @azoxlpf experienced a crash? |
Collaborator
|
@NeffIsBack It seems I didn't get any error because I was testing the samr path. I can actually reproduce the error through the LDAPS path :S . |
32 of 41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


When using the
LDAP add()method with attributes whose values are lists (e.g. servicePrincipalName when adding a computer account), the call raises a TypeError.Cause :
In setComponents(), a generator expression was passed directly instead of being unpacked.pyasn1's setComponents()expects each value as a separate argument, not a single generator object.Fix : Use the unpacking operator
(*)so the generator’s values are passed as individual arguments :For example on Netexec :
Before :
After :