Skip to content

Support channel binding in rbcd.py, dacledit.py and owneredit.py - #1657

Closed
dadevel wants to merge 1 commit into
fortra:masterfrom
dadevel:patch-1
Closed

dadevel wants to merge 1 commit into
fortra:masterfrom
dadevel:patch-1

Conversation

@dadevel

@dadevel dadevel commented Nov 28, 2023 •

Copy link
Copy Markdown
Contributor

This PR uses cannatag/ldap3#1087 to add LDAP Channel Binding support to the RBCD example script.

Demo

@Neustradamus

Copy link
Copy Markdown

@dadevel: A nice PR :)

Linked to Channel Binding:

@dadevel

dadevel commented Mar 20, 2024

Copy link
Copy Markdown
Contributor Author

The PR for Channel Binding in LDAP3 was merged: cannatag/ldap3#1087

@anadrianmanrique anadrianmanrique self-assigned this Apr 11, 2024
@anadrianmanrique anadrianmanrique added the medium Medium priority item label Apr 11, 2024
@anadrianmanrique anadrianmanrique added the on hold Awaiting an action or decision to move forward label Apr 24, 2024
@anadrianmanrique

Copy link
Copy Markdown
Collaborator

Setting this PR on-hold as we are not linking either through requirements or code, against dev version of our dependencies. Let's hope ldap3 new version gets released soon. Thanks

Use cannatag/ldap3#1087 to enable LDAP Channel Binding in multiple example scripts.
@dadevel dadevel changed the title Support channel binding in rbcd.py Support channel binding in rbcd.py, dacledit.py and owneredit.py Jul 9, 2025
@dadevel

dadevel commented Jul 9, 2025 •

Copy link
Copy Markdown
Contributor Author

The PR was rebased on master and now also applies to dacledit.py and owneredit.py.

❯ pip3 install git+https://github.com/cannatag/ldap3@dev
❯ python ./examples/dacledit.py -action read -target 'dc01$' sentinel.local/jdoe:'Password12345' -use-ldaps -use-channel-binding
Impacket v0.13.0.dev0+20250710.1512.7e5ec390 - Copyright Fortra, LLC and its affiliated companies

[*] Parsing DACL
[*] Printing parsed DACL
[*]   ACE[0] info
[*]     ACE Type                  : ACCESS_ALLOWED_OBJECT_ACE
[*]     ACE flags                 : None
[*]     Access mask               : WriteProperty
[*]     Flags                     : ACE_OBJECT_TYPE_PRESENT, ACE_INHERITED_OBJECT_TYPE_PRESENT
[*]     Object type (GUID)        : User-Logon (5f202010-79a5-11d0-9020-00c04fc2d4cf)
[*]     Inherited type (GUID)     : Computer (bf967a86-0de6-11d0-a285-00aa003049e2)
[*]     Trustee (SID)             : Domain Admins (S-1-5-21-1074441319-913972020-3079788021-512)
...

@ShutdownRepo

Copy link
Copy Markdown
Contributor

Any news here?

@dadevel

dadevel commented Jul 17, 2025 •

Copy link
Copy Markdown
Contributor Author

I think these are our possibilities:

  1. Merge this PR as is. Impacket users can opt-in by installing ldap3 from git head themselves. Everyone else would be unaffected.
  2. Merge this PR, but include a change to requirements.txt that pins ldap3 to the currently latest git commit.
  3. Do nothing and keep waiting for an official release of ldap3.

@anadrianmanrique

anadrianmanrique commented Jul 18, 2025 •

Copy link
Copy Markdown
Collaborator

As mentioned, we are still waiting for an official ldap3 release.
We are thinking about a couple of options in case ldap3 release keep delaying, haven't defined yet though:
*monkeypatch current ldap3 ( until new version gets released )
*replace ldap3 dependency with https://pypi.org/project/ldap3-bleeding-edge/ which I understand it's being maintained by @ThePirateWhoSmellsOfSunflowers

@ThePirateWhoSmellsOfSunflowers

Copy link
Copy Markdown
Contributor

Hi,
Even if I'm a ldap3 hardcore fan (just kidding), another solution would be porting it to the impacket's built-in CB implementation #1919 .

🌻

@Neustradamus

Copy link
Copy Markdown

@ThePirateWhoSmellsOfSunflowers: Thanks for your comment!

If one guy can look for Roundcube and kolab/Net_LDAP3, it will be nice :)

Thanks in advance.

@anadrianmanrique

Copy link
Copy Markdown
Collaborator

@ThePirateWhoSmellsOfSunflowers hah! you have a point there! That would imply to adjust impacket ldap implementation and possibly remove ldap dependency. This is something we talked before that we'll have address at some point.
In the meanwhile, which are your thoughts on changing ldap3 dependency with ldap3-bleeding-edege until we decide which final implementation of ldap we'll use ? thanks

@ThePirateWhoSmellsOfSunflowers

Copy link
Copy Markdown
Contributor

TBH I had a lot of problems in the past with impacket's ldap implementation, mostly because impacket.ldap is not fully RFC compliant (eg my issue on attributes encoding). I think that's why most (all ?) impacket's examples are now based on ldap3. Also, to be clear, I do not maintain ldap3-bleeding-edge: I've just merged some PR and published it on pypi. Please do not open issue on it 😆 That said, bleeding-edge is my default branch now for my daily work and it works without any problems.

I think these are our possibilities:

[...]
2. Merge this PR, but include a change to requirements.txt that pins ldap3 to the currently latest git commit.

If I remember correctly, it is not possible to push to pypi a package with pined git url

"Pypi and other standards-conformant package indices do not accept packages that declare dependencies using direct URLs. pip will accept them when installing packages from the local filesystem or from another URL, however." source

🌻

@dadevel dadevel closed this by deleting the head repository Feb 12, 2026
@Neustradamus

Copy link
Copy Markdown

@dadevel: Why have you closed your PR?

@dadevel

dadevel commented Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

Whups, this was not intended. Unfortunately I couldn't reopen the PR. I created #2120 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

medium Medium priority item on hold Awaiting an action or decision to move forward

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants