Repository navigation
Conversation
|
@dadevel: A nice PR :) Linked to Channel Binding: |
|
The PR for Channel Binding in LDAP3 was merged: cannatag/ldap3#1087 |
|
Setting this PR on-hold as we are not linking either through requirements or code, against dev version of our dependencies. Let's hope ldap3 new version gets released soon. Thanks |
Use cannatag/ldap3#1087 to enable LDAP Channel Binding in multiple example scripts.
|
The PR was rebased on master and now also applies to |
|
Any news here? |
|
I think these are our possibilities:
|
|
As mentioned, we are still waiting for an official ldap3 release. |
|
Hi, 🌻 |
|
@ThePirateWhoSmellsOfSunflowers: Thanks for your comment! If one guy can look for Roundcube and kolab/Net_LDAP3, it will be nice :) Thanks in advance. |
|
@ThePirateWhoSmellsOfSunflowers hah! you have a point there! That would imply to adjust impacket ldap implementation and possibly remove ldap dependency. This is something we talked before that we'll have address at some point. |
|
TBH I had a lot of problems in the past with impacket's ldap implementation, mostly because impacket.ldap is not fully RFC compliant (eg my issue on attributes encoding). I think that's why most (all ?) impacket's examples are now based on ldap3. Also, to be clear, I do not maintain ldap3-bleeding-edge: I've just merged some PR and published it on pypi. Please do not open issue on it 😆 That said, bleeding-edge is my default branch now for my daily work and it works without any problems.
If I remember correctly, it is not possible to push to pypi a package with pined git url "Pypi and other standards-conformant package indices do not accept packages that declare dependencies using direct URLs. pip will accept them when installing packages from the local filesystem or from another URL, however." source 🌻 |
|
@dadevel: Why have you closed your PR? |
|
Whups, this was not intended. Unfortunately I couldn't reopen the PR. I created #2120 instead. |
This PR uses cannatag/ldap3#1087 to add LDAP Channel Binding support to the RBCD example script.