Skip to content

test: pin OnnxEvaluator fallback contract - #20

Merged
rabestro merged 1 commit into
mainfrom
test/pin-onnx-evaluator-fallback-contract-13132203637483516668
Sep 6, 2026
Merged

test: pin OnnxEvaluator fallback contract#20
rabestro merged 1 commit into
mainfrom
test/pin-onnx-evaluator-fallback-contract-13132203637483516668

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

This PR adds OnnxEvaluatorFallbackTest.java to pin the fallback contract of OnnxEvaluator.

Changes

  • Verified constructor fallback for null, "", " ", and missing model paths ("no/such/model.onnx"): isLoaded() returns false, constructor does not throw, and close() is safe to call.
  • Verified fallback for non-ONNX files (arbitrary bytes in @TempDir): constructor does not throw, isLoaded() returns false, and close() is safe to call.
  • Verified fallback evaluation on the initial position with dice pool p matches JvmApi.evaluate(state, color) for White (color 0) and Black (color 1).

Verification gates run

  • mise run format
  • mvn -B test -Dtest=OnnxEvaluatorFallbackTest
  • mise run check

Fixes #19


PR created automatically by Jules for task 13132203637483516668 started by @rabestro

Add OnnxEvaluatorFallbackTest to test OnnxEvaluator fallback contract
for null, blank, missing, and non-ONNX model paths.

Gates run:
- mise run format
- mvn -B test -Dtest=OnnxEvaluatorFallbackTest
- mise run check
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sonarqubecloud

sonarqubecloud Bot commented Sep 6, 2026

Copy link
Copy Markdown

@sonarqubecloud

sonarqubecloud Bot commented Sep 6, 2026

Copy link
Copy Markdown

@rabestro rabestro self-assigned this Sep 6, 2026
@rabestro
rabestro merged commit 6069d7a into main Sep 6, 2026
7 checks passed
@rabestro
rabestro deleted the test/pin-onnx-evaluator-fallback-contract-13132203637483516668 branch September 6, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Adding or enhancing automated tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: pin OnnxEvaluator fallback contract (null, blank, missing and non-ONNX model paths)

1 participant