[codex] Sign macOS MCP helper before app binary#294
Merged
forketyfork merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
v0.60.0Intel release got past the install-name rewrite, but failed in the signing phase:The bundle script was signing the main
architectexecutable beforearchitect-mcp. On Intel, the helper starts unsigned, socodesignrejects the main executable while the helper is still an unsigned subcomponent. This changes the order to signarchitect-mcpfirst, thenarchitect, then the app bundle.Checks
bash -n scripts/bundle-macos.shgit diff --check./scripts/bundle-macos.sh zig-out/bin/architect /tmp/architect-bundle-helper-signing-20260428163652 zig-out/bin/architect-mcpcodesign --verify --verbose=2 /tmp/architect-bundle-helper-signing-20260428163652/Architect.appcodesign --verify --verbose=2 /tmp/architect-bundle-helper-signing-20260428163652/Architect.app/Contents/MacOS/architect-mcpcodesign --verify --verbose=2 /tmp/architect-bundle-helper-signing-20260428163652/Architect.app/Contents/MacOS/architectnix develop -c just lintnix develop -c zig build test