Repository navigation
Conversation
Signed-off-by: d3vyce <44915747+d3vyce@users.noreply.github.com>
d3vyce
force-pushed
the
admin-update-notification-check
branch
from
November 13, 2026 15:10
6b4b60b to
84c7c04
Compare
…e and an empty release_check_url - The update notice is withdrawn once it no longer holds (signed out, the check turned off, a newer release) and kept apart from the outcome toasts, which go back to keeping the last few. Dismissals are remembered per release. announce/withdraw replace notice, which main now uses for the inbox. - Admin > Settings keeps what was saved when opened again, and asks for the update status once more after turning the check on, once it has answered. - An empty server.release_check_url hides what an earlier check found, as turning the check off in Admin > Settings does. - Saving the settings locks the row: a switch left out keeps what the last save wrote. - CI's e2e server and the bench run without the release check. - A quiet release check failure logs its causes. - Admin > Jobs lists the release check among the scheduled tasks. - UpdateCheck::request() builds the queued job; newer() returns a bool; the dead serde defaults and the single-column getter are gone, so mcp_enabled and update_check_enabled are required in the API schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
20261113000000 sorted before main's 20261114000000_in_app_notifications.sql and is also the version of the ssh-key-commit-signing branch's migration. sqlx does not detect duplicate versions, so with both merged the server would not start (a primary key violation on a new database, VersionMismatch on one that ran either). A database that already ran this migration under its old version: UPDATE _sqlx_migrations SET version = 20261114193156 WHERE version = 20261113000000; (the file is unchanged, so its checksum still matches). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Checklist
cargo test --workspacepassescargo fmt --allandcargo clippy --workspace --all-targets -- -D warningsare clean.sqlx/,web/openapi.jsonandweb/src/api/schema.d.tsregenerated if queries or the API changedgit commit -s, see CONTRIBUTING.md)