Centralize skills_install_dir and load skills in the deep agent - #183
Merged
Conversation
danchild
marked this pull request as ready for review
July 23, 2026 17:37
danchild
marked this pull request as draft
July 24, 2026 19:53
Collaborator
|
@danchild any specific reason this is still a draft? |
The path `Path(tempfile.gettempdir()) / "forge" / "skills"` was hardcoded identically in agent.py, worker.py, and runner.py. Define it once as a derived property on Settings and import at each call site. Also adds a comment in runner.py noting the assumption that worker and runner share the same host filesystem for skill mounts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Dan Childers <dchilder@redhat.com>
eshulman2
force-pushed
the
gitignore-dynamic-skills
branch
from
August 16, 2026 13:36
abadf6c to
d23ab95
Compare
eshulman2
marked this pull request as ready for review
August 16, 2026 13:36
Update the _get_skill_mounts docstring to describe all three resolution tiers (committed defaults, committed project overrides, runtime-fetched skills) and correct the ensure_skills docstring, which overclaimed that skills_install_dir always keeps runtime artifacts out of the source tree even though it coincides with skills_dir by default. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #179
Summary
skills_install_dir— installation now consistently follows the existing configuredskills_dir(default: the localskills/directory) instead of using duplicated call-site paths.resolve_skill_pathswith askills_install_dirparameter so runtime-fetched project skills are available to Deep Agents without duplicating a source path when the install and source roots are the same.ensure_skillsso callers use the centralized installation path for fetched skill packages andskills.lock.