Repository navigation
fix(client): never use an incompatible daemon (protocol-keyed endpoint + health handshake) - #33
Merged
Merged
Conversation
…n health (#31) A client never uses a daemon built for another protocol and never kills one: the endpoint/lock/log files are named endpoint-p<PROTOCOL>, and /v1/health answers 'ok protocol=<n>', which the start path checks exactly. Old daemons (bare 'endpoint' file) are simply invisible to new clients.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
PROTOCOL = 2inghd-core::endpoint; bump on any request/response field change.*-p<PROTOCOL>, so a pre-handshake daemon (bareendpointfile) or one on another protocol is invisible; the client starts its own daemon beside it. No daemon is ever killed./v1/healthanswersok protocol=<n>; the client's start-path handshake requires an exact match.ok, a daemon on protocol 1, and a matching daemon, against a fake loopback server; endpoint file name is protocol-keyed.