Repository navigation
Batch 19: RUST-017 follows ci/*.py scripts invoked as modules and helper-built test commands - #470
Merged
Merged
Conversation
Local-Gate: v1 tree=6d9067a115b829efc55484f71761b470c85faab0 secs=102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 19, ci.yml part. Selftest (with PyYAML): 1647 tests OK; local gate passed.
Refs #132
RUST-017: false negative in
ci/*.pyscripts invoked as modulesFound while fixing running-process for #132:
ci/independent_spawn.pypasses test-serializing flags, butprecheckreported nothing. There were two causes:uv run --no-project --module ci.independent_spawn, and the scanner only followedci/*.pypaths.test_invocationsnow also follows-m ci.foo/--module ci.foo→ci/foo.py, only for modules underciand only when the file exists.cargo_command("test", …)inci/soldr.py, so the word "cargo" never appears as a command in the script.rust_nocapturenow also treats a script as building a test command when it calls a*cargo*function whose first argument is the literal"test"/"nextest". The rest of the argv is assembled at runtime, so these findings areneeds_review(the rule's existing status for that case), not violations.Result on running-process: six new
needs_reviewfindings inci/independent_spawn.py; the existing findings are unchanged.ci/independent_broker_docker.pystays out of scope: its flag goes to a prebuilt test binary indocker run, not to a cargo test/nextest run, and it runs a single test.Because the module-reference change lives in the shared scanner, RUST-015, RUST-016, CPP-001, TEST-003 and PKG-010 now also see module-invoked scripts. The selftest is unchanged.
Fleet work this batch, outside this repo:
ci/render_workflows.py, the source of truth, soRender-and-diffpasses.pid: 42tripped the USB VID/PID literal guard; it now usesstd::process::id().