Repository navigation
Batch 18: enforce REL-006 -- signing secrets never reach PR jobs (#462) - #469
Merged
Merged
Conversation
…#462) Local-Gate: v1 tree=973a3d53f805f8eeb8c8bbfd9b25ecfaff4a3039 secs=140
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selftest (with PyYAML): 1646 tests OK; local gate passed.
REL-006, partially enforced (#462; the issue stays open for obs-studio adopting the action)
New
ci_lint/rules/macos_signing.py. A job is a signing job if it usesactions/app-signing-macos(local orzackees/ci.yml/...) or references one of the documented signing/notary secrets, directly or through the workflow-levelenv:.pull_request_targetworkflow is a violation, whatever itsif:.pull_request/merge_groupworkflow:if:, it is a violation;if:that limits it to tag refs,releaseorworkflow_dispatch, it passes;if:(including!= 'pull_request'), it isneeds_review.if:, as GATE-012 does.environment:isneeds_review, because the policy also allows repository-level secrets.Still Candidate: checking the signing steps when a repo doesn't use the reference action, and detecting a published unsigned artifact.
Batch 18's other work landed as PRs in fleet repos, none merged by this change:
@v0repo already has the fix.ban_std_pathbuf.