Repository navigation
Fix: Decode null characters in old MAT formats - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were filtering out 0x00 bytes from the
uint16utf-8 encoded char array in legacy MAT-file formats. This resulted in null characters being stripped from the original char array, if any.This PR fixes the bug by constructing a new byte array from (msb, lsb) of each uint16 integer. The MSB is included only if it's non-zero, but the LSB is always included. This ensures an accurate UTF-8 encoded buffer that can be appropriately decoded.
Note: Trailing null characters are still removed by NumPy, however the array
itemsizeordtypecan be used to infer the number of trailing null characters.