Skip to content

Updated Aws Ansible, added elastic IP.#91

Open
Sagargupta16 wants to merge 2 commits intoforem:mainfrom
Sagargupta16:Sagargupta16-patch-1
Open

Updated Aws Ansible, added elastic IP.#91
Sagargupta16 wants to merge 2 commits intoforem:mainfrom
Sagargupta16:Sagargupta16-patch-1

Conversation

@Sagargupta16
Copy link

@Sagargupta16 Sagargupta16 commented Jul 20, 2023

This pull request updates the AWS provisioning playbook to improve compatibility with the latest Ansible modules and enhance functionality. Key changes include replacing deprecated modules, adding register statements for debugging and tracking, and introducing Elastic IP (EIP) association for EC2 instances.

Updates to AWS Modules and Resource Management:

  • Replaced deprecated community.aws.ec2_vpc_endpoint and amazon.aws.aws_s3 modules with amazon.aws.ec2_vpc_endpoint and amazon.aws.s3_object for better compatibility with the latest Ansible versions. [1] [2]
  • Updated the amazon.aws.ec2 module to amazon.aws.ec2_instance for EC2 provisioning, introducing changes like detailed_monitoring, network configuration, and tags instead of instance_tags.

Debugging and State Tracking:

  • Added register statements to multiple tasks (e.g., butane_ignition_stdout, forem_vpc_id_fact, forem_vpcd_route_table_ids_fact) to capture task outputs for debugging and downstream usage. [1] [2] [3]

Elastic IP Management:

  • Introduced a new task to associate an Elastic IP (EIP) with the Forem EC2 instance, ensuring a static public IP for the instance. Updated the debug message to reflect the EIP association.

Minor Fixes and Enhancements:

  • Fixed object key paths in S3 operations by removing unnecessary leading slashes. [1] [2]
  • Improved clarity in debug messages by referencing the EIP's public IP instead of dynamically fetched instance IPs.

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2023

CLA assistant check
All committers have signed the CLA.

@klardotsh
Copy link
Contributor

Neither jdoss or I work at Forem any longer; however @maestromac may be able to review this as/if his time allows.

I'm unsubscribing from this issue, so I won't see further replies in my inbox, but best of luck shepherding this through!

@Sagargupta16
Copy link
Author

@maestromac Can you look into it? Thank you!!

@forem forem deleted a comment from Sagargupta16 Nov 6, 2023
@Sagargupta16
Copy link
Author

@citizen428 Do Review it and Merge

@maestromac maestromac self-requested a review November 15, 2023 19:10
@maestromac
Copy link
Contributor

maestromac commented Nov 15, 2023

@Sagargupta16 Thanks for this contribution. Please kindly avoid tagging individuals. We will review this at our earliest convenience.

@Sagargupta16
Copy link
Author

@Sagargupta16 Thanks for this contribution. Please kindly avoid tagging individuals. We will review this at our earliest convenience.

Ok Thanks

@J-Drakon
Copy link

Thnx @Sagargupta16 This Branch Works for AWS Host..

@dachaeon
Copy link

Thanks @Sagargupta16 this PR got me past the issue with the deprecated module

@Sagargupta16
Copy link
Author

Hi 👋 — this PR has been open for over 2.5 years now. It has:

  • ✅ Clean merge status (no conflicts)
  • ✅ CLA signed
  • ✅ Two independent community members confirming it works (comments from @J-Drakon and @dachaeon)
  • ✅ Fixes deprecated Ansible modules that currently break AWS provisioning

Could any maintainer with merge access take a look?

@maestromac @benhalpern @citizen428 @andygeorge @djuber @nickytonline @jdoss @klardotsh

If this repo is no longer actively maintained, it would be helpful to either:

  1. Merge community-validated fixes like this one, or
  2. Archive the repo so contributors know to maintain forks instead

Thank you!

Copy link
Contributor

@jdoss jdoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants