Skip to content

fix: bug introduced in 7f6c3cda#176

Closed
nikbpetrov wants to merge 2 commits into
forecastingresearch:mainfrom
nikbpetrov:resolve-fix
Closed

fix: bug introduced in 7f6c3cda#176
nikbpetrov wants to merge 2 commits into
forecastingresearch:mainfrom
nikbpetrov:resolve-fix

Conversation

@nikbpetrov
Copy link
Copy Markdown
Collaborator

No description provided.

@houtanb
Copy link
Copy Markdown
Member

houtanb commented Apr 20, 2026

@nikbpetrov there's another bug with this code.

Specifically, _build_question_bank() from orchestration/_io.py does if "hash_mapping.json" not in filename on line 164, but the change in 7f6c3cd stopped creating this file. Now, when a hash mapping is created, it's in hash_mapping_<source>.json

Please:

  1. confirm that the hash mappings that are created are identical between the ones with _source.json and the original ones for all sources that create a hash mapping. These only exist for ACLED and Wikipedia I believe.
  2. fix this and add on top of this create a new PR. What was the reasoning for changing this in the first place?

@houtanb
Copy link
Copy Markdown
Member

houtanb commented Apr 20, 2026

Merged in 02fda0c and ee93a00

@houtanb houtanb closed this Apr 20, 2026
@nikbpetrov nikbpetrov deleted the resolve-fix branch May 16, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants