feat: add tsImportExtension config for TypeScript import paths#100
Closed
nicolaturcato wants to merge 1 commit intomainfrom
Closed
feat: add tsImportExtension config for TypeScript import paths#100nicolaturcato wants to merge 1 commit intomainfrom
nicolaturcato wants to merge 1 commit intomainfrom
Conversation
Add a top-level `tsImportExtension` config field that appends a file extension (e.g. ".js") to relative import paths in generated TypeScript files. This is required for TypeScript projects using `moduleResolution: "nodenext"` or `"node16"`, and prepares for TypeScript 7 which will remove the deprecated `"node10"` resolution mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new top-level
tsImportExtensionconfig option that appends a file extension to relative import paths in generated TypeScript files.Problem: TypeScript 6 deprecated
moduleResolution: "node10", and TypeScript 7 will remove it entirely. Projects using"nodenext"or"node16"resolution require explicit.jsextensions on relative imports — but gotsrpc currently generates extensionless imports like:Solution: When
tsImportExtension: ".js"is set in the YAML config, generated imports become:The option defaults to
""(empty string), so existing behavior is unchanged — this is fully backwards compatible.Usage
Changes
config/config.go— AddTSImportExtensionfield toConfigstructinternal/build/build.go— Passconf.TSImportExtensionthroughrelativeFilePath()→ appended after stripping.tsgotsrpc.schema.json— AddtsImportExtensionto the JSON schemaWhy this matters
moduleResolution: "node10"— projects need"nodenext"or"bundler""nodenext"requires.jsextensions on relative imports.jsextensions are valid across all TS resolution modes, so opting in is always safe