Skip to content

security: redact query strings from URLs in reports #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ronaldtse wants to merge 1 commit into
base: v5
Choose a base branch
from
Open

security: redact query strings from URLs in reports #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/scripts/render_report.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,14 +297,20 @@ def format_failure_detail(failure)
parts = []
if failure["url"]
url = failure["url"]
# Truncate long URLs for readability in tables
display = url.size > 80 ? "#{url[0..77]}..." : url
parts << "[`#{display}`](#{url})"
safe_url = redact_url(url)
parts << "[`#{safe_url}`](#{safe_url})"
end
parts << failure["message"].to_s if failure["message"]
parts.join(" · ")
end

def redact_url(url)
return url unless url.is_a?(String) && url.include?("?")

base = url.split("?").first
"#{base}?…(query redacted)"
end

def pr_footer
footer = "_Generated by `render_report.rb` from `results/*.json` artifacts._"
footer += " \n_Opens or updates the issue when this is a scheduled run._" unless @pr_number
Expand Down
Loading