Skip to content

fix(docs): merge batch assets in combine job to fix client-side routing 404 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ronaldtse merged 1 commit into from
Jun 18, 2026
Merged

fix(docs): merge batch assets in combine job to fix client-side routing 404 #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,13 @@ jobs:
pattern: dist-batch-*
path: batches

- name: Merge batch browse pages
- name: Merge batch browse pages and assets
# Each batch's VitePress build produces its own content-hashed JS chunks
# (app.HASH.js, browse_index.md.HASH.lean.js, etc.) because the page set
# differs per batch. Browse HTML from batch N references batch-N's hashes,
# so we must merge ALL batches' assets/ into dist/assets/ — otherwise
# client-side navigation 404s on the missing chunks (the SSR HTML still
# works on full page refresh, which masked this for a long time).
run: |
for d in batches/dist-batch-*/; do
[ -d "$d" ] || continue
Expand All @@ -258,6 +264,10 @@ jobs:
mkdir -p dist/browse
cp -r "$d/browse/"* dist/browse/ 2>/dev/null || true
fi
if [ -d "$d/assets" ]; then
mkdir -p dist/assets
cp -r "$d/assets/"* dist/assets/ 2>/dev/null || true
fi
done
shell: bash

Expand Down
Loading