Skip to content

fix(gitbrowse): dont prepend a second scheme to plain http remotes #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meleu wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix(gitbrowse): dont prepend a second scheme to plain http remotes #2955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/snacks/gitbrowse.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function M.get_repo(remote, opts)
for _, pattern in ipairs(opts.remote_patterns) do
ret = ret:gsub(pattern[1], pattern[2]) --[[@as string]]
end
return ret:find("https://") == 1 and ret or ("https://%s"):format(ret)
return ret:find("https?://") == 1 and ret or ("https://%s"):format(ret)
end

---@param repo string
Expand Down
2 changes: 2 additions & 0 deletions tests/gitbrowse_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ local git_remotes_cases = {
["https://git.sr.ht/~user/repo"] = "https://git.sr.ht/~user/repo",
["git@git.sr.ht:~user/another-repo"] = "https://git.sr.ht/~user/another-repo",
["https://git.sr.ht/~user/another-repo"] = "https://git.sr.ht/~user/another-repo",
["http://git.example.com/group/subgroup/repo.git"] = "http://git.example.com/group/subgroup/repo",
["http://git.example.com/group/subgroup/repo"] = "http://git.example.com/group/subgroup/repo",
}

describe("util.lazygit", function()
Expand Down
Loading