feat(picker.preview): preview oversized files around target - #2951
Open
soundsmitten wants to merge 1 commit into
Open
feat(picker.preview): preview oversized files around target#2951soundsmitten wants to merge 1 commit into
soundsmitten wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Picker file previews currently reject files larger than
previewers.file.max_size, even when the item has an exact target position. This commonly affects LSP locations in generated or SDK files.For oversized files with
item.pos, preview a bounded slice centered around the target while preserving source line numbers and correctly resolving LSP columns. Regular files continue using the existing full-file preview path, and oversized files without a position keep the existing warning.Also clears stale preview contents on refusal and error paths.
Related Issue(s)
Screenshots
Before
After