fix(picker.lspconfig): take into account when cmd is a function - #2933
Open
dpetka2001 wants to merge 1 commit into
Open
fix(picker.lspconfig): take into account when cmd is a function#2933dpetka2001 wants to merge 1 commit into
dpetka2001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Takes into account when cmd is a function. Not sure about the approach of using Neovim private fields, but couldn't find another solution. The alternative would be to add a guard in
M.preview()whentype(cmd) == "function"and show message that the installed binary could not be determined instead of showingnot installed.I also opted to only do this for items that have
item.enabled, otherwise thepcallwould execute for all available items and in some cases I would getCould not connect to 127.0.0.1:6005, reason: "ECONNREFUSED", which I assume is because thepcallis executed for LSP servers that are not available on the system.Related Issue(s)
Fixes #2932
Screenshots