fix(input): remove history of set lines - #2919
Open
Neovimproved wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After a snacks.input buffer is created, the first line is set to some text, though there is an undo history of this, so I'm creating a pr to ensure that there is no history.
In case it's unclear why this can be useful, here is an example:
You want to rename a variable to make it more clear, so you use the rename feature of snacks; you then add to the variable a suffix, but realize that it would be better if you added a prefix instead. Therefore, you press u some times to reset it to the original variable name but you accidentally press u one too many times, thereby creating friction as you now need to press ctrl+r to return to the original variable name. With no history of the input box ever being set, this problem will not arise.
Related Issue(s)
N/A
Screenshots
When u is pressed nothing is undone, since there is no undo history past this point