Skip to content

fix(image): leaked progress timer and hidden-latched placements broke reopening images #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctbaum wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −2
Open

fix(image): leaked progress timer and hidden-latched placements broke reopening images #2918

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28d9459
fix(image): stop progress spinner timer when the placement is closed
Jul 20, 2026
4ec47ad
fix(image): un-hide placements when their buffer becomes visible again
Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions lua/snacks/image/placement.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,19 +149,28 @@ function M:progress()
vim.api.nvim_buf_set_lines(self.buf, 0, -1, false, {})
vim.bo[self.buf].modifiable = false
local timer = assert(uv.new_timer())
local eid ---@type number?
timer:start(
0,
80,
vim.schedule_wrap(function()
if self:ready() or self.img:failed() or not vim.api.nvim_buf_is_valid(self.buf) then
local valid = vim.api.nvim_buf_is_valid(self.buf)
-- also stop when the placement is closed: `self:ready()` can never
-- become true for a closed placement, and the buffer may stay valid
-- (and be reused for the same file) long after the placement is gone
if self.closed or self:ready() or self.img:failed() or not valid then
timer:stop()
if not timer:is_closing() then
timer:close()
end
-- remove the spinner instead of leaving it behind
if eid and valid then
vim.api.nvim_buf_del_extmark(self.buf, ns, eid)
end
return
end
vim.api.nvim_buf_clear_namespace(self.buf, ns, 0, -1)
vim.api.nvim_buf_set_extmark(self.buf, ns, 0, 0, {
eid = vim.api.nvim_buf_set_extmark(self.buf, ns, 0, 0, {
virt_text = {
{ Snacks.util.spinner(), "SnacksImageSpinner" },
{ " " },
Expand Down Expand Up @@ -538,6 +547,12 @@ function M:update()
self:hide()
return
end
-- the buffer is visible again, so un-hide. Inline placements are
-- hidden/shown explicitly by `snacks.image.inline`, so leave those alone.
if self.hidden and not self.opts.inline then
self.hidden = false
state.hidden = false
end
self.img:place(self)

self:debug("update")
Expand Down