Skip to content

fix(image.inline): keep placements when find_visible returns no images #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlos-algms wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix(image.inline): keep placements when find_visible returns no images #2898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lua/snacks/image/inline.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,13 @@ function M:update()
return conceal
end or conceal
Snacks.image.doc.find_visible(self.buf, function(imgs)
-- `find_visible` is treesitter-backed and can return no images while the
-- parser reparses a rapidly-changing buffer, even when an image is still
-- present. Treating that as "all gone" closes and recreates placements on
-- the next parse, which flickers. Keep placements until it reports images.
if #imgs == 0 then
return
end
local visible = self:visible()
local stats = { new = 0, del = 0, update = 0 }
for _, i in ipairs(imgs) do
Expand Down