UISAUTHCOM-100 - Sunflower CSP - Some capabilities not shown when editing a role but shown in its detail view. - #160
Open
JohnC-80 wants to merge 4 commits into
Open
UISAUTHCOM-100 - Sunflower CSP - Some capabilities not shown when editing a role but shown in its detail view.#160JohnC-80 wants to merge 4 commits into
JohnC-80 wants to merge 4 commits into
Conversation
JohnC-80
changed the title
JohnC-80
changed the title
JohnC-80
requested review from
a team,
Dmytro-Melnyshyn,
usavkov-epam and
zburke
September 1, 2026 16:21
Comment on lines
+75
to
+77
| if (initialCapabilitiesSelectedMap[cap]) { | ||
| delete newSelectedCapabilitiesMap[cap]; | ||
| } |
Contributor
Contributor
Author
There was a problem hiding this comment.
Thanks @Dmytro-Melnyshyn - I switched the cherry-pick order of the UISAUTHCOM-83 commits. No surprise, the cherry-pick went much more smoothly! 😅
… a capability set that includes them. Keep `isInitialDataReady` false while fetching data to prevent stale data from being displayed after the page is reopened. (#133)
…et after selecting a checkbox for a set that includes the initial capabilities. (#136)
…ion. (#154) * add 'direct' fields to useRoleCapabilities output * do less * update tests for 'direct' keys from useRoleCapabilities hook
JohnC-80
force-pushed
the
UISAUTHCOM-100
branch
from
September 2, 2026 13:49
ccea2c9 to
cec8b12
Compare
|
Dmytro-Melnyshyn
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UISAUTHCOM-100
Sunflower backport of UISAUTHCOM-96
The backport required the
isFetchingflags and proper waiting on the initial state from UISAUTHCOM-83's changes as well.We're also able to do this now since MODROLESK-430 was backported to Sunflower. It added the
directfield to capabilities that theuseRoleCapabilitieshook can filter on.Screen capture of Apps in Detail/Edit view and Capability/Set selection behavior:
2026-09-01_10h55_33.mp4