RANCHER-3089 MinIO deprecation and S3 by default

[eldiiar-duishenaliev]

No description provided.

[github-actions]

Code Review Summary

Overall Score: 72/100 ✅ Approved with suggestions

This PR successfully implements the MinIO deprecation strategy and defaults to AWS S3 across the codebase. The changes are consistent and well-intentioned, but there are a few maintainability and documentation concerns to address.

---

✨ Strengths

• Clear migration strategy removing MinIO as a built-in option
• Consistent changes across multiple Jenkinsfiles and parameter files
• Updated UI parameter descriptions to reflect deprecation
• Explanatory comments included in code changes

---

🔴 High Priority Issues

1. Hardcoded S3 type breaks dependency resolution pattern

File: src/org/folio/models/parameters/DependentParametersResolver.groovy:33

The change from dynamic resolveInfraType(clusterName) to hardcoded 'aws' removes flexibility and breaks the established pattern. This makes it impossible for different clusters to use different S3 backends in the future.

Suggestion: Create a dedicated resolveS3Type(clusterName) method that returns 'aws' by default but allows for future extensibility:

result.s3Type = resolveS3Type(clusterName)

private String resolveS3Type(String clusterName) {
  // MinIO is deprecated; all clusters now use AWS S3
  return 'aws'
}

---

🟡 Medium Priority Issues

2. Misleading parameter description

File: vars/folioParameters.groovy:194-195

The description still suggests MinIO is available as a choice when it's no longer supported. This could confuse users.

Suggestion: Update to clarify deprecation:

'Select object storage type: AWS S3 (MinIO deprecated)'

3. Missing migration path documentation

File: src/org/folio/models/parameters/CreateNamespaceParameters.groovy:85

The default value change lacks documentation on how existing deployments using 'built-in' will be handled, risking silent failures.

Suggestion: Add migration documentation and consider a validation utility to detect legacy configurations.

---

📋 Top Recommendations

1. Add migration documentation – Create a changelog entry or migration guide explaining the MinIO deprecation
2. Add deprecation warnings – Log warnings when legacy 'built-in' configurations are encountered
3. Verify backward compatibility – Test existing deployments to ensure they handle the transition gracefully
4. Add test coverage – Ensure S3 type defaults correctly in all scenarios