Skip to content

fix: missing logging after dependencies bump - #942

Open
psmagin wants to merge 1 commit into
masterfrom
MODINV-1411
Open

fix: missing logging after dependencies bump#942
psmagin wants to merge 1 commit into
masterfrom
MODINV-1411

Conversation

@psmagin

@psmagin psmagin commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Fix logging missing

Approach

After the dependabot bump, the classpath ordering changed — log4j-core (position 25) now appears before okapi-common (position 46) in the Maven classpath. The maven-shade-plugin processes JARs in classpath
order and last-write-wins for conflicting files. This caused okapi-common's Log4j2Plugins.dat (which only contains FolioLoggingContext) to overwrite log4j-core's full plugin cache. With no Console or PatternLayout
plugins registered, log4j2 couldn't create the configured appender — complete silence.

Before the commit the order was reversed (okapi-common: 42, log4j-core: 104), so log4j-core won and logging worked.

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MODINV-1411

Screenshots

image

@psmagin psmagin self-assigned this Aug 18, 2026
@psmagin psmagin added the ai label Aug 18, 2026
@psmagin
psmagin marked this pull request as ready for review August 18, 2026 12:42
@psmagin
psmagin requested a review from a team as a code owner August 18, 2026 12:42
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants