fix: missing logging after dependencies bump - #942
Open
psmagin wants to merge 1 commit into
Open
Conversation
Closes: MODINV-1411
Aliaksandr-Fedasiuk
approved these changes
Aug 18, 2026
|
viacheslavkol
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Purpose
Fix logging missing
Approach
After the dependabot bump, the classpath ordering changed — log4j-core (position 25) now appears before okapi-common (position 46) in the Maven classpath. The maven-shade-plugin processes JARs in classpath
order and last-write-wins for conflicting files. This caused okapi-common's Log4j2Plugins.dat (which only contains FolioLoggingContext) to overwrite log4j-core's full plugin cache. With no Console or PatternLayout
plugins registered, log4j2 couldn't create the configured appender — complete silence.
Before the commit the order was reversed (okapi-common: 42, log4j-core: 104), so log4j-core won and logging worked.
Changes Checklist
Related Issues
https://folio-org.atlassian.net/browse/MODINV-1411
Screenshots