MODEXPW-651: Always format email context createdAt with millisecond precision - #752
Merged
Conversation
Instant.toString() omits the fractional part when the nano-of-second is zero, so roughly one order email in a thousand carried a createdAt without milliseconds and OrderEmailContextMapperTest failed at the same rate. A fixed 3-digit instant formatter makes the output deterministic.
|
5 tasks
markusweigelt
approved these changes
Aug 12, 2026
markusweigelt
left a comment
Contributor
There was a problem hiding this comment.
Thx for your work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://folio-org.atlassian.net/browse/MODEXPW-651
Purpose
OrderEmailContextMapperTest.buildContext_setsCreatedAt:177 fails in about .1 % of all runs with this error:
Example: https://github.com/folio-org/mod-data-export-worker/actions/runs/31503434083/job/93819003252
Cause: Instant.toString() omits the fractional part when the nano-of-second is zero, so roughly one order email in a thousand carried a createdAt without milliseconds and OrderEmailContextMapperTest failed at the same rate.
Approach
A fixed 3-digit millisecond instant formatter makes the output deterministic.
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.