MODAT-150: Remove legacy token endpoint and all code associated with it#177
Closed
steveellis wants to merge 5 commits intomasterfrom
Closed
MODAT-150: Remove legacy token endpoint and all code associated with it#177steveellis wants to merge 5 commits intomasterfrom
steveellis wants to merge 5 commits intomasterfrom
Conversation
steveellis
changed the title
julianladisch
approved these changes
Feb 26, 2025
steveellis
commented
Feb 27, 2025
| }, | ||
| { | ||
| "id": "authtoken2", | ||
| "version": "1.1", |
Contributor
Author
There was a problem hiding this comment.
@julianladisch do we want to bump this as well to 2.0?
Contributor
There was a problem hiding this comment.
No, because there is not breaking change in the "authtoken2" APIs.
|
1 similar comment
|
Contributor
|
No longer needed, mod-authtoken will be archived when the Sunflower support period ends 2026-06-30. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/MODAT-150. It was agreed to do this in Sunflower. There also need to be similar pull requests in mod-login, mod-users-bl and mod-login-saml.
/tokenand/refreshtoken._Legacysuffix in the method name.LegacyTokenTenantsclass, tests, and readmeSorry for the gigantic diff with the tests. It is because I decided to fix the indents in this class. Only the tests for the two legacy endpoints (the ones with the
_Legacysuffix have been removed. All other tests are unchanged. Let me know if you would prefer for me to remove the indent fixes to make it easier to review.Tested locally by starting up the core modules, logging in and hitting some core endpoints (mod-users, mod-perms, mod-config) with a token.