Fix: sponsor media upload text preview #1045
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -178,3 +178,60 @@ export const removeFileForSponsorMU = | |
| dispatch(stopLoading()); | ||
| }); | ||
| }; | ||
|
|
||
| export const uploadTextForSponsorMU = | ||
| (pageId, moduleId, text) => async (dispatch, getState) => { | ||
| const { currentSummitState, currentSponsorState } = getState(); | ||
| const { currentSummit } = currentSummitState; | ||
| const { entity: sponsor } = currentSponsorState; | ||
| const accessToken = await getAccessTokenSafely(); | ||
|
|
||
| dispatch(startLoading()); | ||
|
|
||
| const params = { | ||
| access_token: accessToken | ||
| }; | ||
|
|
||
| return putRequest( | ||
| null, | ||
| createAction("DUMMY_ACTION"), | ||
| `${window.SPONSOR_PAGES_API_URL}/api/v1/summits/${currentSummit.id}/sponsors/${sponsor.id}/available-pages/${pageId}/modules/${moduleId}/text`, | ||
| { value: text }, | ||
| snackbarErrorHandler | ||
| )(params)(dispatch) | ||
| .then(({ response }) => { | ||
| dispatch( | ||
| createAction(SPONSOR_MEDIA_UPLOAD_FILE_UPLOADED)({ | ||
| ...response, | ||
| moduleId | ||
| }) | ||
| ); | ||
| }) | ||
| .finally(() => { | ||
| dispatch(stopLoading()); | ||
| }); | ||
| }; | ||
|
|
||
| export const removeTextForSponsorMU = | ||
| (pageId, moduleId) => async (dispatch, getState) => { | ||
| const { currentSummitState, currentSponsorState } = getState(); | ||
| const { currentSummit } = currentSummitState; | ||
| const { entity: sponsor } = currentSponsorState; | ||
| const accessToken = await getAccessTokenSafely(); | ||
|
|
||
| dispatch(startLoading()); | ||
|
|
||
| const params = { | ||
| access_token: accessToken | ||
| }; | ||
|
|
||
| return deleteRequest( | ||
| null, | ||
| createAction(SPONSOR_MEDIA_UPLOAD_FILE_DELETED)({ moduleId }), | ||
| `${window.SPONSOR_PAGES_API_URL}/api/v1/summits/${currentSummit.id}/sponsors/${sponsor.id}/available-pages/${pageId}/modules/${moduleId}/text`, | ||
| null, | ||
| snackbarErrorHandler | ||
| )(params)(dispatch).finally(() => { | ||
|
There was a problem hiding this comment. @santipalenque )(params)(dispatch)
.catch(() => {})
.finally(() => {
dispatch(stopLoading());
});
|
||
| dispatch(stopLoading()); | ||
| }); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@santipalenque Hold the merge on OpenStackweb/openstack-uicore-foundation#319:
5.0.50-beta.1'sCustomDialogwrapschildrenin its ownDialogContent(src/components/mui/CustomDialog/index.js:77there), soPreviewModal,UploadDialogandTextPreviewModalcurrently renderDialogContent > DialogContent + DialogActions(footer buttons inside the scrollable body,PreviewModal'sp: 0defeated), whileTextValueDialoghas noDialogContentof its own. The locally installed5.0.50-beta.0does not wrap children, which is why it did not show during development. Once #319 lands, bump to the release and align the four dialogs to whichever contract shipped — one of the two groups needs a small change either way, the bump alone does not cover it.