Skip to content

fix: add default summits array value on import users popup at sponsor user tab - #1041

Closed
tomrndom wants to merge 4 commits into
masterfrom
fix/import-users-summit-array
Closed

fix: add default summits array value on import users popup at sponsor user tab#1041
tomrndom wants to merge 4 commits into
masterfrom
fix/import-users-summit-array

Conversation

@tomrndom

@tomrndom tomrndom commented Aug 10, 2026

Copy link
Copy Markdown

ref: https://app.clickup.com/t/9014802374/86bbbg5ey

Summary by CodeRabbit

  • Bug Fixes
    • Improved the summit selection experience in the global user import popup.
    • Updated the sponsor-specific user import popup to ensure its title and summit selector display correctly.
  • Quality Improvements
    • Added automated coverage for the sponsor user import workflow to help prevent future display regressions.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 004acc9d-a12b-4aba-9025-69b8eb2f8278

📥 Commits

Reviewing files that changed from the base of the PR and between a2bc52a and dc86747.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (3)
  • package.json
  • src/pages/sponsors/sponsor-page/tabs/sponsor-users-list-per-sponsor/components/__tests__/import-users-popup.test.js
  • src/pages/sponsors/sponsor-users-list-page/components/sponsor-global-import-users-popup.js
💤 Files with no reviewable changes (1)
  • src/pages/sponsors/sponsor-users-list-page/components/sponsor-global-import-users-popup.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/pages/sponsors/sponsor-page/tabs/sponsor-users-list-per-sponsor/components/tests/import-users-popup.test.js

📝 Walkthrough

Walkthrough

The change updates the UI foundation dependency, removes an empty summits prop from the global import popup, and adds a test for per-sponsor import popup rendering.

Changes

Sponsor import popup

Layer / File(s) Summary
Summit selector prop cleanup
src/pages/sponsors/sponsor-users-list-page/components/sponsor-global-import-users-popup.js
Removes the empty summits prop from SummitsDropdown and retains excludeSummitIds.
Per-sponsor popup regression coverage
src/pages/sponsors/sponsor-page/tabs/sponsor-users-list-per-sponsor/components/__tests__/import-users-popup.test.js, package.json
Adds mocked Redux and translation test setup. Verifies the translated title and summit selector. Updates openstack-uicore-foundation from 5.0.45 to 5.0.47.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: smarcet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing the default summits value in the sponsor users import popup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/import-users-summit-array

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

Parsing error: Missing semicolon. (2:8)


Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/pages/sponsors/sponsor-page/tabs/sponsor-users-list-per-sponsor/components/__tests__/import-users-popup.test.js`:
- Around line 15-24: Update the mocked summit-select component to accept and
render the summits prop, then add an assertion in the relevant ImportUsersPopup
test that the rendered summits value is an empty array. Ensure the test fails if
ImportUsersPopup omits summits={[]} while preserving the existing
excludeSummitIds and onChange behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 378f3bd6-8b45-4dda-abc5-ca11e6489600

📥 Commits

Reviewing files that changed from the base of the PR and between 26e2aa7 and eb80b52.

📒 Files selected for processing (2)
  • src/pages/sponsors/sponsor-page/tabs/sponsor-users-list-per-sponsor/components/__tests__/import-users-popup.test.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-users-list-per-sponsor/components/import-users-popup.js

@tomrndom
tomrndom requested a review from smarcet August 10, 2026 19:53
<SummitsDropdown
onChange={setSelectedSummit}
excludeSummitIds={[currentSummit.id]}
summits={[]}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomrndom what is the rationale of this change ?
i do think that if we need it , set up a default value at control level for the prop would be better

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomrndom please review comments

… users tab

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
…opdown, fix test

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom
tomrndom force-pushed the fix/import-users-summit-array branch from dc86747 to 8eea6c1 Compare August 11, 2026 21:53
@smarcet

smarcet commented Aug 12, 2026

Copy link
Copy Markdown

closing this one , this is not the root cause

@smarcet smarcet closed this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants