fix: add default summits array value on import users popup at sponsor user tab - #1041
fix: add default summits array value on import users popup at sponsor user tab#1041tomrndom wants to merge 4 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe change updates the UI foundation dependency, removes an empty ChangesSponsor import popup
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
package.jsonParsing error: Missing semicolon. (2:8) Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/pages/sponsors/sponsor-page/tabs/sponsor-users-list-per-sponsor/components/__tests__/import-users-popup.test.js`:
- Around line 15-24: Update the mocked summit-select component to accept and
render the summits prop, then add an assertion in the relevant ImportUsersPopup
test that the rendered summits value is an empty array. Ensure the test fails if
ImportUsersPopup omits summits={[]} while preserving the existing
excludeSummitIds and onChange behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 378f3bd6-8b45-4dda-abc5-ca11e6489600
📒 Files selected for processing (2)
src/pages/sponsors/sponsor-page/tabs/sponsor-users-list-per-sponsor/components/__tests__/import-users-popup.test.jssrc/pages/sponsors/sponsor-page/tabs/sponsor-users-list-per-sponsor/components/import-users-popup.js
| <SummitsDropdown | ||
| onChange={setSelectedSummit} | ||
| excludeSummitIds={[currentSummit.id]} | ||
| summits={[]} |
There was a problem hiding this comment.
@tomrndom what is the rationale of this change ?
i do think that if we need it , set up a default value at control level for the prop would be better
… users tab Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
…opdown, fix test Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
dc86747 to
8eea6c1
Compare
|
closing this one , this is not the root cause |
ref: https://app.clickup.com/t/9014802374/86bbbg5ey
Summary by CodeRabbit