Skip to content

fix: replace authErrorHandler to fix zindex issues - #1039

Merged
smarcet merged 2 commits into
masterfrom
fix/inventory-error-handler-swal
Aug 12, 2026
Merged

fix: replace authErrorHandler to fix zindex issues#1039
smarcet merged 2 commits into
masterfrom
fix/inventory-error-handler-swal

Conversation

@tomrndom

@tomrndom tomrndom commented Aug 7, 2026

Copy link
Copy Markdown

ref: https://app.clickup.com/t/9014802374/86bb9ypkd

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Bug Fixes
    • Improved success and error notifications across inventory item and inventory-related actions.
    • Standardized feedback for creating, editing, archiving, unarchiving, and managing inventory metadata and files.
    • Inventory item creation now keeps you on the current page after completion instead of redirecting automatically.
    • Error messages are now displayed more consistently when inventory requests fail, helping clarify whether an action succeeded or needs attention.

…issue on errors

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 63508f73-f51a-40a6-9c9f-75c39b4485f9

📥 Commits

Reviewing files that changed from the base of the PR and between ac5df07 and b3071d2.

📒 Files selected for processing (1)
  • src/actions/inventory-shared-actions.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/actions/inventory-shared-actions.js

📝 Walkthrough

Walkthrough

Inventory actions now use snackbar handlers for request errors and structured success notifications. Inventory item creation no longer redirects to the inventory list after success.

Changes

Inventory snackbar migration

Layer / File(s) Summary
Inventory item request and notification handling
src/actions/inventory-item-actions.js
Inventory item requests use snackbarErrorHandler. Create and update operations dispatch structured success snackbars. Creation no longer redirects to /app/inventory.
Shared inventory operation error handling
src/actions/inventory-shared-actions.js
Meta-field, file, archive, and unarchive requests use snackbarErrorHandler. Meta-field type save failures are rethrown after logging.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary change: replacing authErrorHandler to resolve z-index issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/inventory-error-handler-swal

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/actions/inventory-item-actions.js`:
- Around line 236-239: Update saveMetaFieldTypes to rethrow the caught error
after logging it, preserving the rejected promise so saveInventoryItem’s
Promise.all calls cannot dispatch the success snackbar when metadata saving
fails.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f4598391-741e-46b8-9f71-9a2136d87dcc

📥 Commits

Reviewing files that changed from the base of the PR and between 39f4efc and ac5df07.

📒 Files selected for processing (2)
  • src/actions/inventory-item-actions.js
  • src/actions/inventory-shared-actions.js

Comment thread src/actions/inventory-item-actions.js
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom
tomrndom requested a review from smarcet August 7, 2026 21:31

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet
smarcet merged commit f616ef0 into master Aug 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants