Fix: remove all barrel imports and unused deps - #1013
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR replaces shared ChangesFoundation Import Migration
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This PR removes barrel imports and unused dependencies and updates imports accordingly; no actionable merge-blocking risk remains, so it is merge-ready after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/forms/schedule-settings-form/index.js (1)
68-69: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider removing the
console.loginupdateFilterOrder.This debug log was reformatted in this PR but is still a leftover artifact. Since the line was touched, consider removing it to keep production output clean.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/forms/schedule-settings-form/index.js` around lines 68 - 69, Remove the leftover console.log debug statement from updateFilterOrder while preserving the method’s filter ordering behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/forms/schedule-settings-form/index.js`:
- Around line 68-69: Remove the leftover console.log debug statement from
updateFilterOrder while preserving the method’s filter ordering behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1fb8fdac-6467-4938-97d0-7aeb994dcb1c
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (19)
package.jsonsrc/actions/__tests__/dropbox-sync-actions.test.jssrc/actions/dropbox-sync-actions.jssrc/components/forms/badge-form.jssrc/components/forms/badge-type-form.jssrc/components/forms/event-category-group-form.jssrc/components/forms/event-comment-form.jssrc/components/forms/room-form.jssrc/components/forms/schedule-settings-form/index.jssrc/components/forms/tag-group-form.jssrc/components/upload-dialog/index.jssrc/pages/companies/components/__tests__/company-dialog.test.jssrc/pages/companies/components/company-dialog.jssrc/pages/sponsors-global/form-templates/sponsor-inventory-popup.jssrc/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.jssrc/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/client-form/__tests__/client-form.test.jssrc/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/client-form/index.jssrc/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/edit-form/__tests__/edit-cart-form.test.jssrc/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/edit-form/index.js
85342b8 to
f45e16e
Compare
Signed-off-by: sebastian marcet <smarcet@gmail.com>
https://app.clickup.com/t/9014802374/86baz0zt6
Summary by CodeRabbit
Refactor
Tests