Skip to content

Fix: remove all barrel imports and unused deps - #1013

Merged
smarcet merged 2 commits into
masterfrom
fix/upload-input-v3-direct-import
Aug 13, 2026
Merged

Fix: remove all barrel imports and unused deps#1013
smarcet merged 2 commits into
masterfrom
fix/upload-input-v3-direct-import

Conversation

@santipalenque

@santipalenque santipalenque commented Jul 17, 2026

Copy link
Copy Markdown

https://app.clickup.com/t/9014802374/86baz0zt6

Summary by CodeRabbit

  • Refactor

    • Updated form, upload, and sponsor components to use more focused UI component integrations.
    • Simplified internal lifecycle and event-handling code while preserving visible behavior.
    • Existing form workflows and presentation remain unchanged.
  • Tests

    • Updated component test mocks to align with the revised UI integrations.
    • Existing upload, form rendering, prefill, and change-handling scenarios remain covered.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 69caa6d9-6d48-4c4b-a9d9-964fcab13f43

📥 Commits

Reviewing files that changed from the base of the PR and between f45e16e and 4fd1ba2.

📒 Files selected for processing (2)
  • src/pages/sponsors-global/form-templates/sponsor-inventory-popup.js
  • src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/pages/sponsors-global/form-templates/sponsor-inventory-popup.js
  • src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js

📝 Walkthrough

Walkthrough

The PR replaces shared openstack-uicore-foundation barrel imports with direct module imports across forms, upload components, and sponsor cart components. It also updates related Jest mocks and applies minor lifecycle, handler, logging, and JSX syntax cleanup.

Changes

Foundation Import Migration

Layer / File(s) Summary
Form component import cleanup
src/components/forms/*.js
Form components import UI dependencies from specific foundation modules. Several forms also remove unused lifecycle parameters and apply equivalent code simplifications.
Upload component module migration
src/components/upload-dialog/index.js, src/pages/companies/components/company-dialog.js, src/pages/companies/components/__tests__/company-dialog.test.js, src/pages/sponsors-global/form-templates/sponsor-inventory-popup.js, src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js
Upload components use direct module imports. The company dialog test mocks the direct upload module and preserves its callbacks and test attributes.
Sponsor cart module migration
src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/client-form/*, src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/edit-form/*
Sponsor cart components and tests use direct modules for Formik text fields and form item tables. The targeted mocks provide the required default components and helpers.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 4fd1b

This PR removes barrel imports and unused dependencies and updates imports accordingly; no actionable merge-blocking risk remains, so it is merge-ready after normal checks and review.

Possibly related PRs

Suggested reviewers: martinquiroga-exo, smarcet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary changes: removing barrel imports and unused dependencies across the affected files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/upload-input-v3-direct-import

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/components/forms/schedule-settings-form/index.js (1)

68-69: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider removing the console.log in updateFilterOrder.

This debug log was reformatted in this PR but is still a leftover artifact. Since the line was touched, consider removing it to keep production output clean.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/forms/schedule-settings-form/index.js` around lines 68 - 69,
Remove the leftover console.log debug statement from updateFilterOrder while
preserving the method’s filter ordering behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/components/forms/schedule-settings-form/index.js`:
- Around line 68-69: Remove the leftover console.log debug statement from
updateFilterOrder while preserving the method’s filter ordering behavior.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1fb8fdac-6467-4938-97d0-7aeb994dcb1c

📥 Commits

Reviewing files that changed from the base of the PR and between 81151db and 85342b8.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (19)
  • package.json
  • src/actions/__tests__/dropbox-sync-actions.test.js
  • src/actions/dropbox-sync-actions.js
  • src/components/forms/badge-form.js
  • src/components/forms/badge-type-form.js
  • src/components/forms/event-category-group-form.js
  • src/components/forms/event-comment-form.js
  • src/components/forms/room-form.js
  • src/components/forms/schedule-settings-form/index.js
  • src/components/forms/tag-group-form.js
  • src/components/upload-dialog/index.js
  • src/pages/companies/components/__tests__/company-dialog.test.js
  • src/pages/companies/components/company-dialog.js
  • src/pages/sponsors-global/form-templates/sponsor-inventory-popup.js
  • src/pages/sponsors/sponsor-form-item-list-page/components/sponsor-form-item-form.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/client-form/__tests__/client-form.test.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/client-form/index.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/edit-form/__tests__/edit-cart-form.test.js
  • src/pages/sponsors/sponsor-page/tabs/sponsor-cart-tab/components/edit-form/index.js

@smarcet
smarcet force-pushed the fix/upload-input-v3-direct-import branch from 85342b8 to f45e16e Compare August 13, 2026 16:32
Signed-off-by: sebastian marcet <smarcet@gmail.com>

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet
smarcet merged commit 49fbf20 into master Aug 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants