This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Upgrade the spark-on-k8s-operator module to spark-operator-chart-1.1.15 #minor#232
Open
akumor wants to merge 2 commits intoflyteorg:masterfrom
Open
Upgrade the spark-on-k8s-operator module to spark-operator-chart-1.1.15 #minor#232akumor wants to merge 2 commits intoflyteorg:masterfrom
akumor wants to merge 2 commits intoflyteorg:masterfrom
Conversation
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
akumor
force-pushed
the
upgrade-spark-operator-chart-1.1.15
branch
from
12e6bfe to
755efbf
Compare
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
+ Coverage 62.50% 63.95% +1.44%
==========================================
Files 142 142
Lines 8849 9365 +516
==========================================
+ Hits 5531 5989 +458
- Misses 2816 2852 +36
- Partials 502 524 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
|
LGTM, @akumor weird that the coverage is broken |
kumare3
previously approved these changes
Jan 11, 2022
akhurana001
reviewed
Jan 11, 2022
kumare3
previously approved these changes
Feb 1, 2022
EngHabu
reviewed
Feb 2, 2022
go.mod
Outdated
Comment on lines
54
to
74
| k8s.io/api => k8s.io/api v0.20.2 | ||
| k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.20.2 | ||
| k8s.io/apimachinery => k8s.io/apimachinery v0.20.2 | ||
| k8s.io/apiserver => k8s.io/apiserver v0.20.2 | ||
| k8s.io/cli-runtime => k8s.io/cli-runtime v0.20.2 | ||
| k8s.io/client-go => k8s.io/client-go v0.20.2 | ||
| k8s.io/cloud-provider => k8s.io/cloud-provider v0.20.2 | ||
| k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.20.2 | ||
| k8s.io/code-generator => k8s.io/code-generator v0.20.2 | ||
| k8s.io/component-base => k8s.io/component-base v0.20.2 | ||
| k8s.io/cri-api => k8s.io/cri-api v0.20.2 | ||
| k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.20.2 | ||
| k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.20.2 | ||
| k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.20.2 | ||
| k8s.io/kube-proxy => k8s.io/kube-proxy v0.20.2 | ||
| k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.20.2 | ||
| k8s.io/kubectl => k8s.io/kubectl v0.20.2 | ||
| k8s.io/kubelet => k8s.io/kubelet v0.20.2 | ||
| k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.20.2 | ||
| k8s.io/metrics => k8s.io/metrics v0.20.2 | ||
| k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.20.2 |
Contributor
There was a problem hiding this comment.
Per this report, we may have to bump the deps to v0.20.11 for all of these...
Contributor
Author
There was a problem hiding this comment.
Unable to display this organization
The organization does not exist, or you do not have permissions to access it.
I can't view that report, but upgrading to v0.20.11 doesn't sound like it will be a problem. I'll look into bumping that version
Contributor
Author
There was a problem hiding this comment.
@EngHabu I pushed a new commit that changed the deps to v0.20.11 but it looks like snyk is still failing
akumor
force-pushed
the
upgrade-spark-operator-chart-1.1.15
branch
from
29ce44c to
1a7784f
Compare
This upgrades the module to the spark-operator-chart-1.1.15 release. https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/commits/spark-operator-chart-1.1.15 Signed-off-by: akumor <akumor@users.noreply.github.com>
akumor
force-pushed
the
upgrade-spark-operator-chart-1.1.15
branch
from
1a7784f to
3688404
Compare
Signed-off-by: akumor <akumor@users.noreply.github.com>
akumor
force-pushed
the
upgrade-spark-operator-chart-1.1.15
branch
from
3688404 to
3a7f924
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the spark-on-k8s-operator plugin with the goal of fixing support for defining the podSecurityContext for a SparkApplication created by executing a Spark task.
TL;DR
This upgrades the module to the spark-operator-chart-1.1.15 release.
Type
Are all requirements met?
Complete description
I fixed the bug by upgrading the version of the spark-on-k8s-operator to the most recently tagged release
spark-operator-chart-1.1.15and updated the spark flyteplugin code to be compatible.Tracking Issue
flyteorg/flyte#2025
Follow-up issue
NA