This repository was archived by the owner on May 31, 2024. It is now read-only.
Fix missing Type & State info for get launchplans cmd#417
Open
pbrogan12 wants to merge 1 commit intoflyteorg:masterfrom
Open
Fix missing Type & State info for get launchplans cmd#417pbrogan12 wants to merge 1 commit intoflyteorg:masterfrom
pbrogan12 wants to merge 1 commit intoflyteorg:masterfrom
Conversation
pbrogan12
requested review from
EngHabu,
kumare3 and
wild-endeavor
as code owners
Signed-off-by: Patrick Brogan <pbrogan12@gmail.com>
pbrogan12
force-pushed
the
fix-launchplan-command
branch
from
bf4af9c to
640cd52
Compare
kumare3
reviewed
Nov 11, 2023
Contributor
kumare3
left a comment
kumare3
left a comment
There was a problem hiding this comment.
The type field here seems odd, the original expectation seems to be task type which is weird and now adding launchplan type is not very useful 😞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The
get launchplancommand references non-existent fields in theLaunchPlanmessage when generating output, resulting in no data for theTYPEandSTATEcolumns.Type
Are all requirements met?
Complete description
Referenced the correct fields.
Follow-up issue
NA