This repository was archived by the owner on Oct 9, 2023. It is now read-only.
Open
Conversation
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
This was referenced Jun 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 58.60% 60.14% +1.53%
==========================================
Files 168 168
Lines 16256 13302 -2954
==========================================
- Hits 9527 8000 -1527
+ Misses 5887 4459 -1428
- Partials 842 843 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
8 tasks
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR:
stores DeckUri at task running stage to support real-time deck.
with real time deck support flytepropeller#579, propeller can send node event with deck uri at running time, So, admin needs to also store the DeckUri inomation.
In the CreateDownloadLink method, ensure to verify the existence of the URL prior to generating a signed URL. The console invokes CreateDownloadLink to convert the native deck URI into a signed URI. As indicated in FlytePropeller Pull Request #579, the deck URI may not exist yet, necessitating this validation step.
real time deck support includes:
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/