Added script and compiler option to run admin in debug mode#184
Added script and compiler option to run admin in debug mode#184pmahindrakar-oss wants to merge 2 commits intoflyteorg:masterfrom
Conversation
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 63.86% 63.86%
=======================================
Files 105 105
Lines 7286 7286
=======================================
Hits 4653 4653
Misses 2058 2058
Partials 575 575
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com>
|
Interesting can you debug the process in k8s? How? Do you have to start with delve |
|
@kumare3 this is only for admin running outside the k8 cluster. The locally running admin in the IDE can use the k8 deployed services of minio and postgres using port forwarding . There is way to do the same for k8 deployed admin. |
Signed-off-by: Prafulla Mahindrakar prafulla.mahindrakar@gmail.com
TL;DR
Running admin in debug mode requires the compiler output to have debug bits.
Added a new Makefile target compile_debug which does this and the script debug.sh uses dlv to run the admin in debug mode for the serve option
Similarly the script can be modified to run for other commandline options exposed by flyteadmin
Pre-reequisite:

Install dlv : https://github.com/go-delve/delve/blob/master/Documentation/installation/README.md
Setup IDE Debug configuration. The port for DLV should match
eg
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/